-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support net 8 #492
support net 8 #492
Conversation
Super helpful @WeihanLi, appreciate you opening this PR! Please give me a few days to find time to review & try this out, and we can try to merge ASAP! |
By the way, just enabled the CI on this PR. Seems there are some build issues, if you are able to iterate when you have time, we can retry run it. |
Also just in case it helps, this is last year's PR for upgrading to .NET 7, it should be pretty identical: #439 |
Should we drop the |
I would leave this target in for now, as AFAIK there are a few internal teams that still use it even if it's passed support as you say, can remove it at a later point. |
@pdeligia could you please help on the failed tests when you have a time, no idea why it failed 😭 |
I will try to review this and let you know, but just a heads up that it is now unlikely before end of the year (due to really busy schedule this month wrapping up high priority items before the holiday season, and also freezing any code changes for this year). We can try to merge this in Jan. Thanks a lot for your contribution! |
Thanks very much |
try to support .NET 8
contributes to #491